Save-Point

Hello,

I am fairly new to scripts, though I can usually tweak them to work together. However, I am having an issue with getting item/armor/weapon names to properly display in various menus if the color is changed.

I use game_guy's Item Quality script @ Chaos-Project

Content Hidden

The author said he might add compatibility for the systems mentioned later in this post, but I suspect he is too busy.

Code:
#===============================================================================

# Item Quality Colors

# Author game_guy

# Version 1.2

#-------------------------------------------------------------------------------

# Intro:

# Changes the color of the items name according to the items quality. 

# e.g. rare, common, etc.

#

# Features:

# Unlimited Qualities

# Any Color You Want

#

# Instructions:

# Everything you need to configure for the script is below.

# -Setting the Items Quality:

#  Go into the database, click the items, weapons, or armors tab. Type this into

#  the name box after the name.

#  \qty[quality name]

#  e.g. 

#  You have a quality like so

#  Quality['common'] = Color.new(255, 255, 0)

#  You type \qty[common] in the items name

#

# Compatibility:

# Not tested with SDK.

# Most likely will not work with custom menu systems/custom item systems.

# -IF you do use a CMS/CIS

#  -PM me at http://forum.chaos-project.com/index.php?action=profile;u=220

#  -Message me at http://youtube.com/GameGuysProjects

#  -Email me at gameguysprojects@hotmail.com (LAST RESORT, DON'T CHECK OFTEN)

# -Then let me know which custom script you're using and send a copy of it

#  and I'll whip up a compatibility patch if I have the time.

# There is some instructions on how to do it yourself in the topic.

#

# Update History:

# v1.0:

#  -Initial release

# v1.1:

#  -Added support for equip scene

# v1.2:

#  -Improved method of getting quality

#

# Credits:

# game_guy ~ Creator of the script.

# mroedesigns ~ Requesting.

# Leongon ~ Original VX version.

#===============================================================================

module GG_QualityColors

  Quality = {}

  #================================================

  # Color used for all other items without a

  # quality or when a quality level does not exist

  #================================================

  Default_Color = Color.new(255, 255, 255)

  #================================================

  # Add a new line under the qualities already

  # given and type

  # Quality['quality name'] = Color.new(r, g, b)

  #  quality name - name of quality in quotes

  #  r - amount of red

  #  g - amount of green

  #  b - amount of blue

  # Examples below.

  #================================================

  Quality['common'] = Color.new(255, 255, 0)

  Quality['rare'] = Color.new(120, 20, 0)

  Quality['epic'] = Color.new(0, 255, 0)

  Quality['awesome'] = Color.new(80, 80, 240)

end

module RPG

  class Item

    attr_accessor :quality

    alias gg_init_qual_colors_itm_lat initialize

    def initialize

      @quality = ""

      gg_init_qual_colors_itm_lat

    end

    def name

      if @quality == nil

        quality

      end

      return @name

    end

    def quality

      if @quality == nil

        text = @name

        text.gsub!(/\\[Qq][Tt][Yy]\[([0-9A-Za-z_]+)\]/) do

          @quality = $1.to_s

          ""

        end

        if !GG_QualityColors::Quality.include?(@quality)

          @quality = nil

        end

        if @quality == nil

          @quality = 'gg_def'

        end

      end

      return @quality

    end

  end

  class Armor

    attr_accessor :quality

    alias gg_init_qual_colors_arm_lat initialize

    def initialize

      @quality = ""

      gg_init_qual_colors_arm_lat

    end

    def name

      if @quality == nil

        quality

      end

      return @name

    end

    def quality

      if @quality == nil

        text = @name

        text.gsub!(/\\[Qq][Tt][Yy]\[([0-9A-Za-z_]+)\]/) do

          @quality = $1.to_s

          ""

        end

        if !GG_QualityColors::Quality.include?(@quality)

          @quality = nil

        end

        if @quality == nil

          @quality = 'gg_def'

        end

      end

      return @quality

    end

  end

  class Weapon

    attr_accessor :quality

    alias gg_init_qual_colors_wpn_lat initialize

    def initialize

      @quality = nil

      gg_init_qual_colors_wpn_lat

    end

    def name

      if @quality == nil

        quality

      end

      return @name

    end

    def quality

      if @quality == nil

        text = @name

        text.gsub!(/\\[Qq][Tt][Yy]\[([0-9A-Za-z_]+)\]/) do

          @quality = $1.to_s

          ""

        end

        if !GG_QualityColors::Quality.include?(@quality)

          @quality = nil

        end

        if @quality == nil

          @quality = 'gg_def'

        end

      end

      return @quality

    end

  end

end

class Window_Item < Window_Selectable

  def draw_item(index)

    use = false

    item = @data[index]

    case item

    when RPG::Item

      number = $game_party.item_number(item.id)

    when RPG::Weapon

      number = $game_party.weapon_number(item.id)

    when RPG::Armor

      number = $game_party.armor_number(item.id)

    end

    if item.is_a?(RPG::Item) and

       $game_party.item_can_use?(item.id)

      use = true

    end

    if item.quality == 'gg_def'

      self.contents.font.color = GG_QualityColors::Default_Color

    else

      self.contents.font.color = GG_QualityColors::Quality[item.quality]

    end

    x = 4 + index % 2 * (288 + 32)

    y = index / 2 * 32

    rect = Rect.new(x, y, self.width / @column_max - 32, 32)

    self.contents.fill_rect(rect, Color.new(0, 0, 0, 0))

    bitmap = RPG::Cache.icon(item.icon_name)

    opacity = use == true ? 255 : 128

    self.contents.blt(x, y + 4, bitmap, Rect.new(0, 0, 24, 24), opacity)

    self.contents.draw_text(x + 28, y, 212, 32, item.name, 0)

    self.contents.draw_text(x + 240, y, 16, 32, ":", 1)

    self.contents.draw_text(x + 256, y, 24, 32, number.to_s, 2)

  end

end

class Window_Base < Window

  def draw_item_name(item, x, y)

    if item == nil

      return

    end

    bitmap = RPG::Cache.icon(item.icon_name)

    self.contents.blt(x, y + 4, bitmap, Rect.new(0, 0, 24, 24))

    if item.quality == 'gg_def'

      self.contents.font.color = GG_QualityColors::Default_Color

    else

      self.contents.font.color = GG_QualityColors::Quality[item.quality]

    end

    self.contents.draw_text(x + 28, y, 212, 32, item.name)

  end

end

For example, I have a katana and it is average. I just kicked a ghost's a$$ and it crapped out a Katana With a different colored name, (and text prompts) the user understands that a katana that has yellow/gold text name is much more valuable/powerful than just a regular katana.

Basically i cant get the effect or I get an error "Cant convert NilClass to Color"
Ive tried rearranging the scripts and it doesnt help.

Scripts that dont work with Item Quality script:
Grouping and Details @ SP
MultiSlots! @ SP
Chaos Rage Limit System @ Chaos-Project
(I can't add these scripts in code tags simply because the character count would be too large)

If anyone could help me edit/patch the Item Quality script or these other ones, I would greatly appreciate it.

Well, GnD does work with it... to a point. It needs a redefined 'item selection' window in the equip menu. No biggie because of two things: 1) I know you want it to work with both GnD and Multi-Slots and, 2) The patch I am pasting below should be able to guide anyone into fixing GnD alone IF they don't want to use Multi-Slots.

Insofar as Rage-Limit... *shrugs* Gotta look into that, but perhaps this fixes it by accident.

MultiSlots Patch for Item Quality Colors

Code:
#==============================================================================

# ** Item Quality Colors patch for Multi-Slots! 

#------------------------------------------------------------------------------

#    by DerVVulfman

#    version 1.0

#    02-23-2011

#    RGSS / RMXP - Involves Rewrites

#------------------------------------------------------------------------------

#

# * INSTRUCTIONS:

#

#   Paste game_guy's 'Item Quality Colors' below Multi-Slots!

#   Paste this patch below both.

#   Follow game_guy's instructions as normal to apply colors

#

#   This patch allows the color effect to show within both item selection

#   and equipped gear windows in Multi-Slots.  All other item windows are

#   already adapted.

#

#------------------------------------------------------------------------------

#

# * NOTE:   

#   Cursed item colors remain defined by Multi-Slots.

#   Disabled items remain defined by the default system.

#

#==============================================================================

#==============================================================================

# ** Window_EquipItem

#------------------------------------------------------------------------------

#  This window displays choices when opting to change equipment on the

#  equipment screen.

#==============================================================================

class Window_EquipItem < Window_Selectable

  #--------------------------------------------------------------------------

  # * Draw Item

  #     index : item number

  #--------------------------------------------------------------------------

  def draw_item(index)

    item = @data[index]

    x = 4

    y = index * 32

    case item

      when RPG::Weapon  ; number = $game_party.weapon_number(item.id)

      when RPG::Armor   ; number = $game_party.armor_number(item.id)

    end

    if item.quality == 'gg_def'

      self.contents.font.color = GG_QualityColors::Default_Color

    else

      self.contents.font.color = GG_QualityColors::Quality[item.quality]

    end      

    bitmap = RPG::Cache.icon(item.icon_name)

    self.contents.blt(x, y + 4, bitmap, Rect.new(0, 0, 24, 24))

    self.contents.draw_text(x + 28, y, 212, 32, item.name, 0)

    self.contents.draw_text(x + 288, y, 16, 32, MSlots::STRING_SEP, 1)

    self.contents.draw_text(x + 304, y, 24, 32, number.to_s, 2)

  end

end

#==============================================================================  

# ** Window_EquipRight

#------------------------------------------------------------------------------

#  This window displays items the actor is currently equipped with on the

#  equipment screen.

#==============================================================================

class Window_EquipRight < Window_Selectable 

  #--------------------------------------------------------------------------

  # * Draw Item Name

  #     item        : item

  #     x           : draw spot x-coordinate

  #     y           : draw spot y-coordinate

  #     translucent : translucent

  #--------------------------------------------------------------------------

  def draw_item_name(item, x, y, translucent = true)

    return if item == nil

    bitmap = RPG::Cache.icon(item.icon_name)

    if translucent

      self.contents.blt(x, y + 4, bitmap, Rect.new(0, 0, 24, 24), 128)

      self.contents.font.color = disabled_color

    else

      self.contents.blt(x, y + 4, bitmap, Rect.new(0, 0, 24, 24))

      if item.quality == 'gg_def'

        self.contents.font.color = GG_QualityColors::Default_Color

      else

        self.contents.font.color = GG_QualityColors::Quality[item.quality]

      end      

    end    

    self.contents.font.color = MSlots::COLOR_CURSED if item.cursed

    self.contents.draw_text(x + 28, y, 212, 32, item.name)

  end  

end

Disabled items (like trying to equip a 2-handed sword and a regular shield) forces the shield to use the default 'disabled' color. Disabled color is translucent/transparent. And yeah... you can add both the color effect from game_guy's script and the Two handed flag from Multi-Slots in the name. Happy

Thanks! MultiSlots! works perfectly now. You Rock!!!

Grouping and Details, not so much.
I only use GnD for the Details at the moment. However, I noticed a conflict with CRLS. If you have GnD in your project, and you enter the Soul Rage menu (while in battle) the cursor/selecting window is gone! Meaning if you have multiple skills attached to an item, or if you have multiple items with skills equipped, you are S.O.L. and can only use the first skill on the first item. I used a new project file to test this compatibility, and everything works until GnD is added to the scripts.

also no. the patch didn't accidentally fix CRLS display, but I wanted to report the above conflict. I will try to make your patch work with CRLS if I can. I fixed it!
the patch didn't accidentally fix the script because Blizzard uses draw_item_name_srs as the method name. thus the humble patch merely rewrites that method.

GnD is a great script (for what I use it for currently). It seems that it just doesn't want to play nice with Item Quality Colors or CRLS... I can't get the item name to properly display the colors in the details window. When I try to find where the detail window gets the item name, I get pretty confused. I'm looking for a method that draws the name and defines the text color so I can reference it in a patch, but I just see a bunch of what appear to be temporary variables. The code in this system is pretty confusing to me... but other than copy/paste and print, my scripting knowledge is nearly non-existent lol.

EDIT: By studying your patch (and ripping off your formatting, sorry) I made a patch for Chaos Rage Limit System. Now when you view the item name in the Soul Rage equipment menu, the proper color is displayed. Here is my patch:

My patch based on yours

Save-Point

Save-Point

xuroth

DerVVulfman

xuroth