Save-Point

Hey everyone.

I'm looking for a simple way to add multiple auto-states on weapons and armors.
Example: A cursed Sword which gives a permanent barrier but also a poison state on the wielder.

Right now I'm doing it like this in Scene_Battle

Content Hidden

Code:
#==============================================================================

# ** Scene_Battle (part 2) (Adding auto-states on equipment)

#------------------------------------------------------------------------------

#  This class performs battle screen processing.

#==============================================================================

class Scene_Battle

  #--------------------------------------------------------------------------

  # * Start Pre-Battle Phase

  #--------------------------------------------------------------------------

  def start_phase1

    # Shift to phase 1

    @phase = 1

    # Weapon Auto-State

    if $game_party.actors.size >= 1

      if $game_party.actors[0].weapon_id == 1

        $game_party.actors[0].add_state(60)

        $game_party.actors[0].add_state(61)

      end

    end

    if $game_party.actors.size >= 2

      if $game_party.actors[1].weapon_id == 1

        $game_party.actors[1].add_state(60)

        $game_party.actors[1].add_state(61)

      end

    end

    if $game_party.actors.size >= 3

      if $game_party.actors[2].weapon_id == 1

        $game_party.actors[2].add_state(60)

        $game_party.actors[2].add_state(61)

      end

    end

    if $game_party.actors.size == 4

      if $game_party.actors[3].weapon_id == 1

        $game_party.actors[3].add_state(60)

        $game_party.actors[3].add_state(61)

      end

    end

    if $game_party.actors.size == 5

      if $game_party.actors[4].weapon_id == 1

        $game_party.actors[4].add_state(60)

        $game_party.actors[4].add_state(61)

      end

    end

    if $game_party.actors.size == 6

      if $game_party.actors[5].weapon_id == 1

        $game_party.actors[5].add_state(60)

        $game_party.actors[5].add_state(61)

      end

    end    

    # Clear all party member actions

    $game_party.clear_actions

    # Set up battle event

    setup_battle_event

  end

end

I know that's very rough but its works so far.
But I'm 100% sure there are better scripts for this, I just can't find any.

I will only tell you that an iterator would make it simple and short, look for information regarding how to use iterators in Ruby.

I'm honest and I have no clue how to use that right to make my code short and simple.

Okay now I got this:

Content Hidden

I think this is way better than before.
But not nearly "good".

The array "actors" is not necessary. $game_party.actors is already an array.

Code:
$game_party.actors.each do |actor|

   if actor.weapon_id == 21

      actor.add_state(60)

      actor.add_state(61)

   end

end

Noting your original post. I will make the following suggestion.

Set your weapon states to constants.

Example

Code:
CURSED = [60,61]

ANCIENT = [59]

HOLY = [18]

This way you can assign them easier with little limit to the number.

Code:
if actor.weapon_id == ??? #(whatever weapon)

  for state_id in CURSED

    actor.add_state(state)

  end

end

Thank you.

I will add this to the code.

Save-Point

Save-Point

Mel

kyonides

Mel

Mel

BeJeremiah

BeJeremiah

Mel