Save-Point
ACBS FIX SCRIPT #2: Advanced Cry Correction - Printable Version

+- Save-Point (https://www.save-point.org)
+-- Forum: Material Development (https://www.save-point.org/forum-8.html)
+--- Forum: Scripts Database (https://www.save-point.org/forum-39.html)
+---- Forum: RPGMaker XP (RGSS) Engine (https://www.save-point.org/forum-116.html)
+---- Thread: ACBS FIX SCRIPT #2: Advanced Cry Correction (/thread-7522.html)



ACBS FIX SCRIPT #2: Advanced Cry Correction - DerVVulfman - 08-09-2019

ACBS FIX SCRIPT #2
Advanced Cry Correction
Version: 1.0



Introduction
This fixes a major flaw with the ACBS (Atoa's CBS) by Victor Sant. The bug was caused by an oversight where the action ID (skill ID, Item ID, etc) was not correctly synced in a method that played audio effects. If a BASE audio effect was set, only that would play. But if one was not set, the system was set to crash.



Script
Code:
#==============================================================================
# ** ACBS FIX SCRIPT #2:  Advanced Cry Correction
#------------------------------------------------------------------------------
#     by DerVVulfman (08/08/2019) MM/DD/YYYY
#------------------------------------------------------------------------------
#  The ACBS System has a flaw with advanced cry system.  This fixes a major
#  flaw that prevents individual cries by skill or item id from functioning.
#==============================================================================



#==============================================================================
# ** Object
#------------------------------------------------------------------------------
# Superclass of all other classes.
#==============================================================================

class Object
  #--------------------------------------------------------------------------
  # * Advanced Battlecry play
  #     battler : battler that will play the sound effect
  #     type    : type of the sound effect
  #     action  : action that will play the sound effect
  #--------------------------------------------------------------------------
  def battle_cry_advanced(battler, type, action)
    bc = battler.actor? ? Actor_Battle_Cry : Enemy_Battle_Cry
    if bc[battler.id] != nil and bc[battler.id][type] != nil
      if bc[battler.id][type][action] != nil
        base = bc[battler.id][type][action].dup
      else
        base = bc[battler.id][type]['BASE'].dup
      end
      sound = base[rand(base.size)].dup
      Audio.se_play('Audio/SE/' + sound[0], sound[1], sound[2])
      return true
    end
    return false
  end
end



Instructions
Paste this directly below the ACBS | Scene_Battle 4 script so it can take effect and replace the broken methods in question.



FAQ
A surprise, this is the second bug I've seen in the system..!



Compatibility
Specifically geared for the ACBS.



Terms and Conditions
Free for use with just due credit required.


RE: ACBS FIX SCRIPT #2: Advanced Cry Correction - aeliath - 08-09-2019

Another great fix, amazing work right there! THANK YOU SO MUCH for this, I hope this helps other people if they wish to use this amazing system.