Combo Attacks Script Help

[MechanicalPen]

\o/ Flipping fixed it! Wouldn't you know it, the problems with the Skill Points being incorrect were found in the "Window_Skill SP Cost" script. XD

Seriously though, I would like to walk you through the steps I used to fix this bug in hopes of teaching you to be a better bug fixer. First, I fiddled with the arrow keys while trying to select a magic skill. The SP Cost changed whenever I pushed the arrow keys, but only up to a certain point. Furthermore I could push the arrow keys the same number of times in the opposite direction to get it back to the normal behavior. Knowing a thing or two about how windows work, I guessed that even though all the skills were drawn correctly, the data list might have had extra entries.

From the scripts you posted, I can tell you thought the very same thing! Nothing I could do to that part of the script could fix it, however. The second thing I noticed was the the window that displayed the SP Cost was separate from the one the displayed the skill names. I did a ctrl+shift+F (find in all) for "EP Cost" to figure out where that window was.

The script that it found was 'Window_Skill Status' which doesn't contain... well, much of anything! However, the script listed right above that one was "Window_Skill SP Cost" and that sounds like something that displays SP costs. Since those were what we were having trouble with, I took a look inside.

And guess what I found? Something about 'draw_item's and 'data.push's that looked like the ones in Win_Skill. The very same thing you thought could be the problem in the second post! So kudos to you for figuring that bit out.

But the 'data.push's in the 'Window_Skill SP Cost' script were a little different than the ones in the 'Combo Attacks Script.' If you would like to try and fix it yourself, that is where you should look. Otherwise, look in this spoiler for the solution.

"The bugfix"

Change:

Code:

for i in 0...@actor.skills.size
      skill = $data_skills[@actor.skills[i]]
      if (@skill_kind == -1)
        if skill != nil
          @data.push(skill)
        end
      else
        if skill != nil and skill.element_set.include?(@skill_kind)
          @data.push(skill)
        end
      end
    end

To:

Code:

for i in 0...@actor.skills.size
      skill = $data_skills[@actor.skills[i]]
      if (@skill_kind == -1)
        if skill != nil and not $combo_skill.include?(skill.id)
          @data.push(skill)
        end
      else
        if (skill != nil and skill.element_set.include?(@skill_kind)) and not $combo_skill.include?(skill.id)
          @data.push(skill)
        end
      end
    end

Edit: Unfortunately, there is similar bug when selecting a target...