BIG MAPS and Anti-Lag

[kyonides]

Something people usually forget is that operators in Ruby are a bit weird.

and follows the logical order, i.e. if check1 and check2

&& does it in the reverse order, e.g. if check2 && check1

There operator precedence DOES matter! && has a higher precedence than and.

So print name and pattern to verify which one isn't a string and when one of them is a regular expression or Regexp instead. Why? That's because the scripter forgot that passing a single string, whether it's the first or second parameter, to a match operator will always throw a TypeError in Ruby. That should NOT happen at all. This happens when you include strings and regular expressions. In my humble opinion he should have picked just one of them to reduce the number of tests needed to run the method.

Solution? I guess it could be something like...

Code:

if (pattern.is_a?(String) and name.include?(pattern)) ||
        (pattern.is_a?(Regexp) and !(pattern =~ name).nil?)

I don't think name should ever be a Regexp. Not even a mad scientist like would ever dare to make it a regular expression.